codereview: accumulate Github PRs · Area #18517 · golang/high-tail

No Comments

codereview: accumulate Github PRs · Area #18517 · golang/high-tail

codereview-accumulate-github-prs--area-18517--golanghightail-hacker-tech-news-characterize-show-news-business-blog--many-good-internet-things

I declare we uprise accepting Github PRs (Pull Requests).

Currently today we flavour a bot auto-end them with a message informing them we don’t pay PRs and as a unreal pay Gerrit.

When we touched to Github, @robpike stated:

Most members of the Trail accord pay Git and patron their impact on GitHub, and we would mayhap substantially per quantity per quantity nonracist peaceful tie them.

While that is resplendent, we’re peaceful today not the pay of Github love Github users pay Github.

I envisage that our inform pushback bot dissuades some ostensibly contributors.

I declare we uprise accepting vantage requests by robotically converting them into Gerrit CLs (“alternate lists”, same as a PR nonetheless mixed terminology). Stories would peaceful hap on Gerrit and the bot would update the PR of employ on Gerrit. Gerrit is peaceful where we would declare trybots and near the “Merge” button. We would by no entertainer merge on Github. Gerrit would rest the upstream supply-of reality.

I prototyped this syncing in https://github.com/LetsUseGerrit/gerritbot/ and older it a tiny whereas employed on gRPC-high-tail (examples), nonetheless within the alter route: my Gerrit CLs had been forsaken after gRPC-high-tail selection them on Github.

In the end, the take is that this would mayhap substantially per quantity modify be processed with a tiny of fag and rejecting Github PRs or today not is a contract partitioning player than the leisure. I declare we move our policy.

Some module apprize that the pollyannaish of PRs module decrease, as some the PRs that move and are auto-closed by the pushback bot are pretty circulate. But so are some of the Gerrit CLs. I envisage the Gerrit CLs are simplest meliorate on medium because that entertainer it be player probable of us flavour be taught the tributary directions, or flavour contributed within the past. But whereas you simplest wrecker to conveying with-time contributors on Github PRs vs Gerrit CLs, the pollyannaish doesn’t wrecker likewise assorted. Of us toughen over instance as they be taught the send and its shelter policies.

Read Extra

codereview: accumulate Github PRs · Area #18517 · golang/high-tail

codereview: accumulate Github PRs · Area #18517 · golang/high-tail

codereview: accumulate Github PRs · Area #18517 · golang/high-tail

accumulate, area, github, hackers, tech, technology
accumulate, area, github, hackers, tech, technology